emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b306bc5e6d 2/3: Improve prompt of 'image-dired' command


From: Eli Zaretskii
Subject: Re: master b306bc5e6d 2/3: Improve prompt of 'image-dired' command
Date: Sat, 24 Sep 2022 11:18:59 +0300

> --- a/lisp/image/image-dired.el
> +++ b/lisp/image/image-dired.el
> @@ -553,7 +553,7 @@ If the number of image files in DIR exceeds
>  `image-dired-show-all-from-dir-max-files', ask for confirmation
>  before creating the thumbnail buffer.  If that variable is nil,
>  never ask for confirmation."
> -  (interactive "DImage-Dired: ")
> +  (interactive "DImage-Dired (directory): ")

IMO, the new prompt is not much better than the old one.  They both
assume that just by prepending "Image-" to something resembling the
prompt of "C-x d" is enough to explain what the command wants.  I see
a lot of space for confusion here, especially for non-native English
speakers.

The doc string of the command says:

  Make a thumbnail buffer for all images in DIR and display it.
  Any file matching `image-dired--file-name-regexp' is considered an
  image file.

So I don't think the analogy with Dired holds, and therefore something
like

  Show thumbnails for directory:

would be a better prompt.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]