[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with f
From: |
Po Lu |
Subject: |
Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets. |
Date: |
Thu, 08 Sep 2022 21:31:55 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Stefan Kangas <stefankangas@gmail.com> writes:
> branch: master
> commit e90a457c46ca9463bf77cab2d34513c45269c938
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
> * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.
> ---
> src/xrdb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xrdb.c b/src/xrdb.c
> index faeea04a53..5ff25dde14 100644
> --- a/src/xrdb.c
> +++ b/src/xrdb.c
> @@ -589,14 +589,14 @@ main (int argc, char **argv)
> char query_class[90];
>
> printf ("Name: ");
> - gets (query_name);
> + fgets (query_name, 90, stdin);
>
> if (strlen (query_name))
> {
> char *value;
>
> printf ("Class: ");
> - gets (query_class);
> + fgets (query_class, 90, stdin);
>
> value = x_get_string_resource (&xdb, query_name, query_class);
>
TESTRM has not worked for a long time and relies on XLIB_ILLEGAL_ACCESS,
which is not okay to use anymore.
I would rather it be removed.