emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b1e9151: Enable the native display of BMP images on Haiku


From: Eli Zaretskii
Subject: Re: master b1e9151: Enable the native display of BMP images on Haiku
Date: Sat, 26 Mar 2022 16:18:54 +0300

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 26 Mar 2022 20:33:36 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> --- a/src/image.c
> >> +++ b/src/image.c
> >> @@ -11555,12 +11555,16 @@ syms_of_image (void)
> >> 
> >>  #if HAVE_NATIVE_IMAGE_API
> >>    DEFSYM (Qnative_image, "native-image");
> >> -# ifdef HAVE_NTGUI
> >> -  DEFSYM (Qgdiplus, "gdiplus");
> >> -  DEFSYM (Qshlwapi, "shlwapi");
> >> +
> >> +#if defined HAVE_NTGUI || defined HAVE_HAIKU
> >>    DEFSYM (Qbmp, "bmp");
> >>    add_image_type (Qbmp);
> >> -# endif
> >> +#endif
> >> +
> >> +#ifdef HAVE_NTGUI
> >> +  DEFSYM (Qgdiplus, "gdiplus");
> >> +  DEFSYM (Qshlwapi, "shlwapi");
> >> +#endif
> >>  #endif
> >> 
> >>    defsubr (&Sinit_image_library);
> 
> > Shouldn't you now remove SEFSYM for Qbmp from haikuimage.c?
> 
> Probably, but it doesn't hurt to keep multiple DEFSYMs around right?

It's better not, I think.  We don't do that elsewhere, do we?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]