emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Re: Early backtrace.


From: Alan Mackenzie
Subject: Re: [PATCH]: Re: Early backtrace.
Date: Mon, 31 Jan 2022 16:54:09 +0000

Hello, Eli.

On Mon, Jan 31, 2022 at 14:42:24 +0200, Eli Zaretskii wrote:
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Mon, 31 Jan 2022 10:30:35 +0100
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
> >  Emacs developers <emacs-devel@gnu.org>

> > Am So., 30. Jan. 2022 um 12:08 Uhr schrieb Alan Mackenzie <acm@muc.de>:

> > > It also fixes a bug in signal_or_quit (eval.c) where previously there
> > > was:

> > >       specbind (Vdebugger, Qdebug);

> > > , which had the effect of binding the contents of Vdebugger (namely
> > > Qdebug) to itself.  Correct would have been:

> > >       specbind (Qdebugger, Qdebug);

> > > , binding the symbol Qdebugger to Qdebug.



> > Good find, thanks. Independent of the rest of the patch, should we
> > install this one-character fix on the release branch?

> Yes, please.

OK, I'll do that, but it's slightly more than one character to change.
A DEFSYM for Qdebugger is also needed in syms_of_eval.

> > Maybe that would even make commit
> > 07edc28bdbfeeaeb1008b4fe21bfda586feae562 unnecessary? (Haven't
> > checked, though.)

> I wouldn't touch that part, as it cannot possibly do any harm.

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]