Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap.

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 10 Dec 2021 15:37:32 +0000
> Cc: emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +** Convert defvar foo-mode-map to defvar-keymap
> >> +Verify the conversion by comparing the value of the keymap before
> >> +converting it and after (you can see the value in 'C-h v').
> >
> > Really?  What are the benefits of doing such a conversion?  I see only
> > a lot of code churn and a risk of breaking things that are perfectly
> > fine as they are.
> 
> I think this is a good entry-level exercise for someone who is looking
> to start contributing to Emacs.

I think it shouldn't be done, not by beginners, not by anyone.

> Please feel free to revert it if you disagree.

I will, unless Lars disagrees.

> > And that goes for many of the changes in this direction you made
> > lately, btw: why are we making all those changes for purely stylistic
> > reasons?
> 
> Yes, I'm not making any friends doing that, am I?  :-)
> 
> Personally, I do such things when I don't have the time or energy to
> invest in anything significant.  I can come up with other ways to
> procrastinate, of course.

Can I convince you to do more useful things when that happens?  How
about reading a random section in the manual, or a random set of doc
strings, and making them more clear?