emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: DPS font backend uses the wrong font


From: Alan Third
Subject: Re: DPS font backend uses the wrong font
Date: Sun, 17 Oct 2021 18:35:29 +0100

On Sun, Oct 17, 2021 at 09:35:21PM +0800, Po Lu wrote:
> Po Lu <luangruo@yahoo.com> writes:
> 
> > As of 2028df78, font backends are required to use s->font instead of
> > s->face->font, even in the NS port, because s->face is now set to mouse
> > face by redisplay independently of terminal specific code.
> 
> BTW, this also means a great deal of code in the NS port that looks
> like:
> 
>       if (s->hl == DRAW_MOUSE_FACE)
>         {
>           face = FACE_FROM_ID_OR_NULL (s->f,
>                                        MOUSE_HL_INFO 
> (s->f)->mouse_face_face_id);
>           if (!face)
>             face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
>         }
>       else
>         face = FACE_FROM_ID (s->f, s->first_glyph->face_id);
> 
> Can be removed now, because it's no longer necessary for
> terminal-specific code to worry about the mouse face like this.

Hmm, I wonder if this means mouse face will be honoured in SVG images
now...?

That would be nice because I couldn't work out how to find the mouse
face where we construct the image struct.
-- 
Alan Third



reply via email to

[Prev in Thread] Current Thread [Next in Thread]