emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch proposal: display symbol source code in help buffers


From: Ihor Radchenko
Subject: Re: Patch proposal: display symbol source code in help buffers
Date: Fri, 01 Oct 2021 17:08:14 +0800

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Ihor Radchenko <yantar92@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  Stefan Kangas <stefankangas@gmail.com>,
>>   arthur.miller@live.com,  emacs-devel@gnu.org
>> Date: Fri, 01 Oct 2021 15:05:57 +0800
>> 
>> +            ;; Save mark for the old location, unless we just opened
>> +            ;; the buffer or the point is not actually going to move.
>> +            (unless (or (= 1 (point))
>> +                        (= (point) position))
>> +              (push-mark nil t))
>
> This assumes that if point is at BOB, we "just opened the buffer"?
> What if the user moves point, then returns to BOB?

Lars applied the patch without (= 1...) clause, so it does not matter
anymore.

> And why do you use 1 instead of point-min?

Mostly because I prefer to state it explicitly to not confuse BOB with
beginning of a narrow.  Is there any scenario when BOB is not at 1?

Best,
Ihor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]