emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Buffer-local process environments


From: Michael Albinus
Subject: Re: [PATCH] Buffer-local process environments
Date: Sat, 28 Aug 2021 14:47:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Augusto Stoffel <arstoffel@gmail.com> writes:

Hi Augusto,

> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index af7b8292b7..1c11b7707e 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1783,6 +1783,8 @@ compilation-start
>           (replace-regexp-in-string "-mode\\'" "" (symbol-name mode))))
>        (thisdir default-directory)
>        (thisenv compilation-environment)
> +         (bufferenv (when (local-variable-p 'process-environment)
> +                      (cons exec-path process-environment)))

W/o further reading, this cannot be right. Elements of
`process-environment' have always the syntax "VAR=VALUE". You add only a
VALUE (`exec-path') in `bufferenv'. I understand your intention, using
`bufferenv' as transportation vehicle, but I believe this is
mis-designed, and good for trouble. If not now, then later.

(I will review your proposal later, when this is fixed.)

Best regards, Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]