emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] externals/transient 65f4eac 3/3: Silence type-compiler


From: Stefan Monnier
Subject: Re: [elpa] externals/transient 65f4eac 3/3: Silence type-compiler
Date: Wed, 25 Aug 2021 13:36:20 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>     While this variable is conceptually unused,
>     the macro-expansion actually uses it.
> ---
>  lisp/transient.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/transient.el b/lisp/transient.el
> index 4cbc421..4d1df2f 100644
> --- a/lisp/transient.el
> +++ b/lisp/transient.el
> @@ -3266,7 +3266,7 @@ Show the first one that is specified."
>          (transient--describe-function (oref transient--prefix command)))
>      (if-let ((prefix (get (transient--suffix-command obj) 
> 'transient--prefix))
>               (manpage (oref prefix man-page))
> -             (_ (not (eq this-command (oref transient--prefix command)))))
> +             (- (not (eq this-command (oref transient--prefix command)))))

Hmm... indeed.  We could fix the macro to first bind the values to an
internal variable and then let-bind it to the "official" variable name
which would avoid this bit of ugliness.

But the generated code would be a bit less efficient because our
byte-compiler is not good at variable-propagation.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]