emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: Convenience function for changing font family


From: Eli Zaretskii
Subject: Re: Patch: Convenience function for changing font family
Date: Sun, 08 Aug 2021 09:32:39 +0300

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Fri, 6 Aug 2021 14:33:48 +0530
> 
> Here's a patch for changing the font family on the fly. It's similar to
> changing font weight using the keyboard.

Thanks, but how is this supposed to work?  After applying the patch
and loading facemenu, "M-x facemenu-set-family RET" does nothing, not
even prompts for the font family; and clicking

 Edit->Text Properties->Face->family

from the menu bar just shows "menu-bar edit Text Properties fc f" in
the echo area.

I think one problem is that the facemenu machinery, as you use it,
expects "family" to be a face, and there's no such face.

Did you test this with Emacs 28 from the master branch?  Or what am I
missing?

P.S. Please also provide a doc string for the new function(s), and add
a :version tag to any defcustom you add or change.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]