Re: [PATCH] lisp/files.el: Add `file-name-set-extension`

[Colin Woodbury]

The copyright assignment process was finalized for me today, so this should be good-to-go.

Thanks!

Colin

On Thu, 10 Jun 2021, at 07:40, Colin Woodbury wrote:

Good catch Michael, thank you, I had completely forgotten about Windows.  I've updated the patch.

Cheers,

Colin

On Thu, 10 Jun 2021, at 00:46, Michael Albinus wrote:

"Colin Woodbury" <colin@fosskers.ca> writes:

> Hi all,

Hi Colin,

> +          ((equal ?/ (string-to-char (substring file -1))) (error "Filename is a directory: %s" filename))

This shall be (directory-name-p file) . You cannot assume that ?/ is

always the directory separator, for example on MS Windows.

Best regards, Michael.

Attachments:

• file-name-with-extension.patch