Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations

[João Távora]

On Tue, Jun 1, 2021 at 9:22 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > ;; current
> > (20.18251486 3 0.3386851209999975)
> > (19.646946365 3 0.3477981569999997)
> > (20.10486081 3 0.34829881900000004)
> >
> > ;; allocate extra cons and non-capturing function
> > (21.353061817 3 0.3557993659999994)
> > (21.124979874999998 3 0.361779398000003)
> > (21.009165698 3 0.36675408300000356)
>
> So, the current design is better?

It's neglibily faster IMO (and only in this particular stage).  Could
be slower later on, where the group function is called again on the
same completion twice more.

> I see no need to re-hash the whole discussion around it, unless you find
> an actual concrete problem with it (rather than an aesthetic dislike).

A confusing API and a complicated minibuffer.el are concrete problems
IMHO.

> Let's move on.  If we can't agree on this design which has no clear
> flaw, I can't imagine we'll ever come to an agreement for the
> replacement of `affixation-function`

You may not think it worth it, but the complicated minibuffer.el hampers
my efforts to experiment with replacements for affixation-function. Nothing
insurmountable but I for one like tighter API's and code.

João Távora