Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations

[Daniel Mendler]

On 6/1/21 5:09 PM, João Távora wrote:
> Gregory Heytings <gregory@heytings.org> writes:
> 
>>>
>>> Regarding the annotations I disagree. The default *Completions* UI
>>> also annotates by default with not possibility for the user to turn
>>> this off, except by overwriting the `annotation-function` itself for
>>> example by advising `completion-metadata-get`.
>>>
>>
>> And this is (for me, and likely for others) one of the differences
>> between the *Completions* buffer and the minibuffer.  I'm not against
>> making it possible to display annotations in the minibuffer for those
>> who want to see them there, but hardcoding them is IMO wrong.  And as
>> I said users might want to display these annotations with their own
>> formatting, e.g. to display only some but not all of them in the
>> minibuffer.
> 
> Nothing is hardcoded and icomplete-vertical-mode is a new feature.  So I
> woundn't go crazy on customization for customization sake.  Daniel's
> proposal was simple enough and it was a no brainer to take.  We're still
> discussing the API to do annotations anyway.

I agree with not going overboard with customization possibilities. I am
in particular worried by the duplication of customization variables.
There is `completions-detailed` which is pretty much unused for example.
Adding another guard variable on top does not sound good. But I think a
global guard variable (per completion UI) to disable annotations in that
particular UI is something to consider.

Daniel