[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/files.el: Add `file-name-set-extension`
From: |
Colin Woodbury |
Subject: |
Re: [PATCH] lisp/files.el: Add `file-name-set-extension` |
Date: |
Sun, 30 May 2021 18:16:20 -0700 |
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-468-gdb53729b73-fm-20210517.001-gdb53729b |
Hi Andreas (et al.),
After asking around, it seems like letting `string-trim` fail naturally is indeed the canonical thing to do here, especially since with `toggle-debug-on-error` we're able to get the full call-stack if we need it. I've altered the patch (see attached) accordingly. Thanks for your patience.
Cheers,
Colin
On Wed, 26 May 2021, at 10:39, Andreas Schwab wrote:
That's exactly what should happen.
Andreas.
--
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
file-name-set-extension.patch
Description: Text Data
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, (continued)
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Basil L. Contovounesios, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Colin Woodbury, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Stefan Monnier, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Colin Woodbury, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Stefan Monnier, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Colin Woodbury, 2021/05/25
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Andreas Schwab, 2021/05/26
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Colin Woodbury, 2021/05/26
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`, Andreas Schwab, 2021/05/26
- Re: [PATCH] lisp/files.el: Add `file-name-set-extension`,
Colin Woodbury <=