emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for


From: Karl Fogel
Subject: Re: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Tue, 25 May 2021 00:38:22 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

On 09 May 2021, Eli Zaretskii wrote:
From: Karl Fogel <kfogel@red-bean.com>
Cc: Matthias Meulien <orontee@gmail.com>, drew.adams@oracle.com, larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Date: Sun, 09 May 2021 13:37:52 -0500

My inclination would be to do this by having `bookmark-bmenu-load' just refer readers to `bookmark-load', and then improving the latter's doc string. That way if future changes are made to `bookmark-load's behavior, we wouldn't need to remember to update `bookmark-bmenu-load's doc string too.

Thoughts?

I'll have thoughts when I see the result ;-)

Heh, fair enough. My inquiry was about the general practice of having one function's doc string referring out to another function's. But it sounds like you have no objection to that, and neither do I.

If the attached doc patch looks sensible, I'll commit it.

Best regards,
-Karl

Attachment: 0001-Improve-bookmark-bmenu-load-doc-string.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]