emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lexical-binding change in find-file.el breaks emacs ada-mode tests


From: Stephen Leake
Subject: lexical-binding change in find-file.el breaks emacs ada-mode tests
Date: Fri, 21 May 2021 11:25:54 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt)

See bug 48535.

This breaks emacs ada-mode automated tests, which rely on evaluating
elisp forms in Ada comments.

git bisect says this commit is to blame:

commit: c105017c44d4a679f7af739b2c0390b2c7850569
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Tue Apr 6 17:06:07 2021 -0400

    * lisp/find-file.el: Make the commands oblivious to mouse/non-mouse

    (ff-find-other-file): Add `event` argument.
    (ff-find-other-file-other-window): Rename from
    `ff-mouse-find-other-file-other-window` and use this new argument.
    (ff-mouse-find-other-file, ff-mouse-find-other-file-other-window):
    Make them obsolete aliases.
    (ff-upcase-p): Remove unused `start` and `end` arguments and
    simplify accordingly.

I looked thru the diff, but I didn't see anything obvious, so I'm
blaming the lexical-binding change. But I don't know how to fix it.

-- 
-- Stephe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]