Recent commits broke Emacs on MacOS arm64 native-comp

[Matthew Leach]

Hello,

Two recent commits on master have broke Emacs on my machine:

46e4704e2abca4d264a43965f92eab7608211ee6

This commit causes an Emacs native-comp build to segfault. See attached
build log. When I remove this commit, Emacs builds fine.

43701a84367b76ccc93ad46f89110486988eec10

This commit causes emacs to abort whenever the minibuffer is shown. To
reproduce this, get a fresh install of spacemacs, open Emacs and allow
it to build. Once all the packages have been downloaded and built, press
`SPC f f'. This causes Emacs to crash with a SIGABRT. Partial backtrace:

--8<---------------cut here---------------start------------->8---
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x0000000193b58e78 libsystem_kernel.dylib`__pthread_kill + 8
libsystem_kernel.dylib`__pthread_kill:
->  0x193b58e78 <+8>:  b.lo   0x193b58e98               ; <+40>
    0x193b58e7c <+12>: pacibsp
    0x193b58e80 <+16>: stp    x29, x30, [sp, #-0x10]!
    0x193b58e84 <+20>: mov    x29, sp
Target 0: (Emacs) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x0000000193b58e78 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x0000000193b8ab98 libsystem_pthread.dylib`pthread_kill + 292
    frame #2: 0x0000000193a6ae14 libsystem_c.dylib`raise + 32
    frame #3: 0x00000001046381e8 Emacs`terminate_due_to_signal + 204
    frame #4: 0x00000001046388e4 Emacs`emacs_abort + 20
    frame #5: 0x0000000104618f9c Emacs`ns_term_shutdown + 132
    frame #6: 0x0000000104521020 Emacs`shut_down_emacs + 328
    frame #7: 0x00000001046381b0 Emacs`terminate_due_to_signal + 148
    frame #8: 0x00000001046388e4 Emacs`emacs_abort + 20
    frame #9: 0x0000000104549410 Emacs`Factive_minibuffer_window + 232
    frame #10: 0x000000014adbcf00 
window-0d1b8b93-d2367f9f.eln`F6d696e696275666665722d77696e646f772d6163746976652d70_minibuffer_window_active_p_0
 + 48
    frame #11: 0x0000000104590a00 Emacs`funcall_subr + 308
    frame #12: 0x00000001045904c8 Emacs`Ffuncall + 644
    frame #13: 0x00000001045c7768 Emacs`exec_byte_code + 1500
    frame #14: 0x0000000104590dc0 Emacs`funcall_lambda + 740
    frame #15: 0x0000000104590440 Emacs`Ffuncall + 508
    frame #16: 0x00000001045906ec Emacs`funcall_nil + 12
    frame #17: 0x00000001045906ac Emacs`run_hook_with_args + 296
--8<---------------cut here---------------end--------------->8---

Regards,
-- 
Matt

emacs-segfault-build.txt
Description: Text document