emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.


From: Karl Fogel
Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Wed, 05 May 2021 00:24:07 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Revised patch attached, with the option now defaulting to nil (i.e., to the old behavior) as per discussion. Review/comments welcome.

Lars, you wrote this regarding v1 of this patch:

...the first line [of the doc string] should be a complete sentence.

It actually was a complete sentence even in v1, but I think I know what you meant. However, the "Non-nil means..." phrasing is found throughout Emacs -- I counted over 1000 places with this quick check:

 $ find lisp -name "*.el" | xargs grep '"Non-nil means'

(One can add '-C3' to grep to see that they are indeed `defcustom's and `defvar's.)

I guess that people are used to it, so I left that phrasing as-is.

Best regards,
-Karl

Attachment: bookmark-menu-deletion-confirmation-patch-v2.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]