Re: [PATCH] Speed up project-kill-buffers

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  (defun project--buffer-list (pr)
>>    "Return the list of all buffers in project PR."
>> -  (let (bufs)
>> +  (let ((remote-project-p (file-remote-p (project-root pr)))
>> +        bufs)
>>      (dolist (buf (buffer-list))
>> -      (when (equal pr
>> -                   (with-current-buffer buf
>> -                     (project-current)))
>> +      (when (and (let ((remote (file-remote-p (buffer-local-value 
>> 'default-directory buf))))
>> +                   (if remote-project-p remote (not remote)))
>> +                 (equal pr
>> +                        (with-current-buffer buf
>> +                          (project-current))))
>>          (push buf bufs)))
>>      (nreverse bufs)))
>
> How 'bout using `file-in-directory-p`?

I didn't know about that function! Just tried it out and it seems that
the patch below is even faster, as project-current does not have to be
invoked for every buffer, remote or not.

>         Stefan
>

-- 
        Philip K.

>From eb9f32e1007eaa90a1b5487ac009b38182d6260b Mon Sep 17 00:00:00 2001
From: Philip K <philipk@posteo.net>
Date: Mon, 3 May 2021 11:35:41 +0200
Subject: [PATCH] Reduce number of method invocations in project--buffer-list

* project.el (project--buffer-list): Use file-in-directory-p
---
 lisp/progmodes/project.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index d47d9d77e6..aa2fc1690f 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -1120,11 +1120,12 @@ project-kill-buffer-conditions
 
 (defun project--buffer-list (pr)
   "Return the list of all buffers in project PR."
-  (let (bufs)
+  (let ((root (project-root pr))
+        bufs)
     (dolist (buf (buffer-list))
-      (when (equal pr
-                   (with-current-buffer buf
-                     (project-current)))
+      (when-let ((file (or (buffer-file-name buf)
+                           (buffer-local-value 'default-directory buf)))
+                 ((file-in-directory-p file root)))
         (push buf bufs)))
     (nreverse bufs)))
 
-- 
2.30.2