[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] * lisp/international/mule-cmds.el (deactivate-input-method):
|
From: |
Eli Zaretskii |
|
Subject: |
Re: [patch] * lisp/international/mule-cmds.el (deactivate-input-method): Tiny improve. |
|
Date: |
Wed, 28 Apr 2021 18:03:10 +0300 |
> Date: Wed, 28 Apr 2021 20:33:23 +0800 (CST)
> From: tumashu <tumashu@163.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>
> >> - (funcall deactivate-current-input-method-function))
> >> + (when (functionp deactivate-current-input-method-function)
> >> + (funcall deactivate-current-input-method-function)))
> >
> >Thanks, but could you please explain why this is needed? IOW, in
> >which use case did you see this function called when
> >deactivate-current-input-method-function wasn't a function?
>
> Yes, I have faced some bugs of pyim in evil environment, sometimes, this
> variable maybe is nil.
> I can not find why.
I see traces of using defadvise there. Could it be that the advice
calls deactivate-input-method incorrectly?