Re: master c622627: * Clean-up temporary eln test-suite directory when exiting (bug#48060)

[Michael Albinus]

akrl@savannah.gnu.org (Andrea Corallo) writes:

Hi Andrea,

>  lisp/startup.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/startup.el b/lisp/startup.el
> index a21372a..3513ab7 100644
> --- a/lisp/startup.el
> +++ b/lisp/startup.el
> @@ -550,7 +550,9 @@ It is the default value of the variable `top-level'."
>        ;; testsuite, add a temporary folder in front to produce there
>        ;; new compilations.
>        (when (equal (getenv "HOME") "/nonexistent")
> -        (push (make-temp-file "emacs-testsuite-" t) comp-eln-load-path)))
> +        (let ((tmp-dir (make-temp-file "emacs-testsuite-" t)))
> +          (add-hook 'kill-emacs-hook (lambda () (delete-directory tmp-dir 
> t)))
> +          (push tmp-dir comp-eln-load-path))))

This expects, that Emacs tests are run only via calling test/Makefile
(which sets $HOME to "/nonexistent"). This is not true, tests can also
be started interactively.

And I find it problematic to have a dependency in startup.el to a
Makefile of the test directory.

Best regards, Michael.