emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio


From: Dmitry Gutov
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata
Date: Tue, 27 Apr 2021 18:47:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 27.04.2021 04:59, tumashu wrote:

My ideal UI would probably be more like this:
https://emacs-lsp.github.io/lsp-ui/images/lsp-xref.gif (though perhaps
with a slightly different layout). Meaning, a posframe popup showing the

Wow, cool!!!
it seem to many packages use posframe at the moment,

I use Ivy with posframe (because I like to have a reliably frame-centered popup, and by frame usually has 4 windows), but the package above actually implements its own rendering based on overlays. Probably because they wanted it to be functional in terminal as well.

is is a good idea
to move posframe to emacs.git?

My personal rule of thumb is, it should be in emacs.git only if it's going to be used by some code inside Emacs. At the moment it seems unlikely also because of the same factor: we don't have a similar feature/library for rendering popups in terminal Emacs. A few users ago Eli (I think?) said it could be created based on the same approach that renders menu in the terminal mode, but that still has not materialized.

It's also unfortunate that the core developers usually give GNU ELPA a wide berth instead of reviewing the code and making suggestions (in the most essential packages, at least). That could be another reason to add posframe to the core, but without at least someone among our windowing system experts paying attention to it, there would be no point.

And without a terminal mode counterpart/support, it's unlikely to be used in the core code.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]