Re: Adding transient to Emacs core

[Jonas Bernoulli]

martin rudalics <rudalics@gmx.at> writes:

>  >> If you say that (pop-up-windows nil) is not a valid customization, I
>  >> would strongly disagree with that.
>  >
>  > I have addressed this by let-binding that variable to t around the call
>  > to display-buffer.  There's just no way around that because transient's
>  > buffer just has to be displayed somewhere other than the selected
>  > window.
>
> This would constitute a major bug in `display-buffer' - `pop-up-windows'
> is semi-obsolete ("provided for backward compatibility only").  The
> canonical way to do what you want is to provide an
>
> (inhibit-same-window . t)
>
> action alist entry.

We were already using (inhibit-same-window . t) and indeed if I remove
the let-binding, then things continue to function.  I am removing this
unnecessary kludge again.