Re: [PATCH] Fix M-x gdb when debugging over Tramp

[Jim Porter]

On Thu, Apr 8, 2021 at 5:58 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Jim Porter <jporterbugs@gmail.com> writes:
>
> Hi Jim,
>
> > Here's a pair of patches (one against the latest git revision, and one
> > against the emacs-27 branch) to fix debugging via M-x gdb over Tramp.
> > There were two problems:
> >
> > 1) In `gdb-jsonify-buffer', when replacing the "fullname" with a Tramp
> > path, the wildcard was greedy, resulting in only one "fullname" being
> > replaced. This had the effect of rendering it impossible to have more
> > than one breakpoint, as all but the first breakpoint would have
> > unmodified "fullname"s. This fix isn't needed for Emacs 28, since
> > `gdb-jsonify-buffer' was replaced with a more-accurate parser for
> > GDB/MI.
> >
> > 2) In `gdb-frame-handler', `gdb-selected-file' needs to be the *local*
> > file path, since that's what `gud-last-frame' expects. Without this,
> > the overlay arrow for the current line in the source buffer won't
> > show.
>
> From my POV these patches look OK, but I'm a very occasional gdb
> user. It would be great if somebody else could verify.

Thanks for taking a look. Of course, if anyone with more experience
using M-x gdb could take a look, that would be helpful too.

> I have also the impression that this is related to bug#39408, bug#28392
> and bug#44151. Perhaps this could be checked, and in case of yes, I
> would much appreciate if we could solve all of these bugs.

Indeed, it looks like bug#39408 is my issue (1) above, and bug#28392
is my issue (2). bug#44151 looks like it's done(ish): the first part
is something you've already fixed in Tramp, and the second part
(mentioned in comment 11) is a duplicate of bug#28392.

Given that these are already tracked as bugs, should I just submit
patches to both bug#39408 and bug#28392? I'd have to rearrange my
existing patches slightly, but that's easy.

- Jim