|
From: | Basil L. Contovounesios |
Subject: | Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) |
Date: | Fri, 26 Mar 2021 15:33:18 +0000 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes: >> What's the performance impact here? This is going to be called a whole >> bunch of times when the user hits TAB... > > It should be OK to do the condition-case wrapping around the loop rather > than within it, so the performance impact should be negligible. "Around the loop" means "around completing-read", and I'm not sure we want to catch all its errors. It makes sense to me to protect read-extended-command-predicate (or at least its specific instance of command-completion-default-include-p), as that can be polluted by user and external library code. But other errors would be a bug in M-x, no? -- Basil
[Prev in Thread] | Current Thread | [Next in Thread] |