|
From: | Basil L. Contovounesios |
Subject: | Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) |
Date: | Fri, 26 Mar 2021 15:18:59 +0000 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Michael Albinus <michael.albinus@gmx.de> writes: > "Basil L. Contovounesios" <contovob@tcd.ie> writes: > >> + ;; Demote any errors so M-x continues to work. >> + (condition-case-unless-debug err >> + (funcall (get symbol 'completion-predicate) symbol buffer) >> + (error >> + (message "command-completion-default-include-p: %s: %S" symbol err) > > I would also report buffer. That's what I had initially, but I found it a bit noisy since the buffer is usually the current one (at least in the read-extended-command case for sure). > Otherwise, it LGTM (but I'm not Lars :-) Thanks, -- Basil
[Prev in Thread] | Current Thread | [Next in Thread] |