[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: modus-themes ELPA and etc/themes
From: |
Protesilaos Stavrou |
Subject: |
Re: modus-themes ELPA and etc/themes |
Date: |
Sun, 21 Mar 2021 00:49:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On 2021-03-20, 21:31 +0000, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> OK, so it's a definite no for moving `etc/themes`.
>>
>> How 'bout moving just `modus-themes.el` (it's a fresh new file, so the
>> forensics aspect shouldn't matter that much, especially since the real
>> Git history is in the upstream repository rather than in emacs.git
>> anyway)? Part of the reason why `modus-themes.el` could be treated
>> differently is that it actually contains a fair bit of ELisp code, so it
>> would make sense to compile it.
>
> [Just for posterity - this was touched on in bug#45068 to an extent.]
A very short summary of that bug, as pertains to this point:
+ A file that resides in etc/themes cannot be loaded with just a
(require) call because it is not in the load-path.
+ We need such a functionality to load the main modus-themes.el from
within modus-{operandi,vivendi}-theme.el. The former contains the
bulk of the code, while the latter two expand the relevant parts into
actual themes.
+ To make everything work inside etc/themes we had to use the new
'require-theme' function, which accounts for that directory.
--
Protesilaos Stavrou
protesilaos.com