[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Little improvements on pulse.el
From: |
Stefan Monnier |
Subject: |
Re: Little improvements on pulse.el |
Date: |
Thu, 11 Mar 2021 10:35:57 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> 2. The name and the docstring mention the use with hooks, but would be
Indeed, and that is generally a bad idea: docstring should aim to
describe what the function does rather than when/where it's expected to
be used [insert general disclaimer that all generalizations are bad].
> 5. The code on 'pulse-lighten-highlight' can be significantly improved
> by replacing 'pulse-int-to-hex' and 'pulse-color-values-to-hex' with
> 'color-gradient' from color.el.
I think pulse.el was written before color.el was added to Emacs, so
I wouldn't be surprised that there's room for simplifying and improving
the code.
Stefan
Re: Little improvements on pulse.el, Juri Linkov, 2021/03/10
Re: Little improvements on pulse.el,
Stefan Monnier <=