[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el
From: |
Stefan Monnier |
Subject: |
Re: master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el |
Date: |
Wed, 24 Feb 2021 16:19:03 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> Would the patch below fix this problem more directly?
>
> [...]
>
>> - (while (re-search-forward "^[ \t]*(quail-define-package" nil t)
>> + (while (re-search-forward "^[ \t]*(quail-define-package[ \t\n]*\""
>> nil t)
>
> I'm not sure? This all ends up as a (register-input-method ...) call,
> which is a function, from which I inferred that literal strings aren't
> necessarily required here (i.e., that you can quail-define-package with
> a variable name as the first element).
But IIRC those that we want to extract are specifically those that
are already "fully computed". In theory we could miss some things like
(let ((name "foo"))
(quail-define-package name ...))
but that seems very unlikely.
Stefan