[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix some failing tests in BSD systems
From: |
Dmitry Gutov |
Subject: |
Re: [PATCH] Fix some failing tests in BSD systems |
Date: |
Wed, 6 Jan 2021 03:38:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 05.01.2021 00:25, Daniel Martín wrote:
Thanks, it fixes the test failures for me. However, I still see the
extra '/' if I follow these steps:
- make TAGS
- emacs -Q
- Visit src/xdisp.c
- M-? in redisplay_internal
Perhaps there are more places that need that patch.
Thanks, that's the third place, and probably the final one.
In the meantime, plot thickens: as pointed out privately by Davis
Herring, using 'find' on a directory without a trailing slash will fail
if the directory is a symlink (it will only list the symlink itself).
At this point we could double down on this approach and use the '-H'
argument (though grep-find-template doesn't make this easy), or return
to your original patch. Or yet alternatively, paper over this inside the
xref-location-group defmethod. The two alternatives attached.
So I guess I should ask: was the particular behavior annoying by itself,
or is it only a problem because of the failing test?
I also wonder whether all macOS users see this, or whether it's maybe
fixed in some latest version of BSD find. Because it's apparently
(arguably) a bug: https://unix.stackexchange.com/a/320440/166215
find-no-doubleslash-h.diff
Description: Text Data
find-no-doubleslash-postprocess.diff
Description: Text Data
- [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Eli Zaretskii, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Eli Zaretskii, 2021/01/03
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Eli Zaretskii, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/04
- Re: [PATCH] Fix some failing tests in BSD systems,
Dmitry Gutov <=
- Re: [PATCH] Fix some failing tests in BSD systems, Daniel Martín, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Stefan Monnier, 2021/01/06
- Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/06
Re: [PATCH] Fix some failing tests in BSD systems, Dmitry Gutov, 2021/01/03