[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnus-group-read-ephemeral-search-group -- Something Changed?
From: |
T.V Raman |
Subject: |
Re: gnus-group-read-ephemeral-search-group -- Something Changed? |
Date: |
Fri, 6 Nov 2020 10:29:07 -0800 |
Not sure, will need to try it once you've added the check for the
older keyEric Abrahamsen writes:
> "T.V Raman" <raman@google.com> writes:
>
> > you're correct. But please keep the backward compatibility, since I
> > need emacspeak to work with both the released emacs 27, as well as
> > emacs-28 built from head which I use --- that latter is what helps me
> > make sure that when Emacs-28 does get released, emacspeak works out of
> > the box with it.
>
> Okay, will do. Are you sure that checking for the nnir key symbol is
> enough to make everything work correctly?
>
> > > Eric Abrahamsen writes:
> > > "T.V Raman" <raman@google.com> writes:
> > >
> > > > I use gnus-group-read-ephemeral-search-group to search GMail via imap,
> > > > see details in this blog article:
> > > > https://emacspeak.blogspot.com/2020/09/searching-gmail-from-gnus.html
> > > >
> > > > About 8 weeks or so, that function
> > > > gnus-group-read-ephemeral-search-group was declared obsolete but its
> > > > replacement was supposed to be backward compatible and everything
> > > > worked until about 2 days ago --- or from memory I updated/rebuilt
> > > > emacs yesterday and it's broken today.
> > > >
> > > > Broken: How,
> > > >
> > > > Now, when I invoke the afore-mentioned function
> > > > I get an additional prompt after supplying the query and calling it
> > > > with the imap-search spec it expects. A quick look in git logs didn't
> > > > show anything suspicious, other than the file was changed with
> > > > comments to the effect that that function is obsolete.
> > >
> > > Yes, this function has changed in the past couple of days, as nnir.el
> > > has been obsoleted. I'm guessing you're calling
> > > `gnus-gorup-read-ephemeral-search-group' with a spec that contains an
> > > `nnir-search-spec' key? That key is now called `gnus-search-spec'.
> > >
> > > I can provide better backwards compatibility by continuing to check for
> > > the `nnir-search-spec' and `nnir-group-spec' keys, I guess I didn't
> > > think people would be using that function programmatically in this way.
> > >
> > > Would you be willing to show me exactly how you're calling this
> > > function? I can be more certain about providing backwards compatibility
> > > that way, and might be able to suggest some alterations.
> > >
> > > Sorry for the roadbump,
> > >
> > > Eric
> >
> > --
> > ♉Id: kg:/m/0285kf1 🦮♉
>
> "T.V Raman" <raman@google.com> writes:
>
> > P.S. how am calling that function was documented in the blog article I
> > mentioned; here is a pointer to the code in Git to make it easier.
> > https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L133
>
> I'll take a look at this over the weekend. Maybe I can suggest some more
> changes to take advantage of the new gnus-search.el library.
>
> Thanks for the report,
> Eric
--
♉Id: kg:/m/0285kf1 🦮♉
--
♉Id: kg:/m/0285kf1 🦮♉
- gnus-group-read-ephemeral-search-group -- Something Changed?, T.V Raman, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Eric Abrahamsen, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, T.V Raman, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Pankaj Jangid, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Eric Abrahamsen, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Pankaj Jangid, 2020/11/06
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Eric Abrahamsen, 2020/11/07
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Pankaj Jangid, 2020/11/07
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Eric Abrahamsen, 2020/11/07
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Stefan Monnier, 2020/11/07
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, Eric Abrahamsen, 2020/11/07
- Re: gnus-group-read-ephemeral-search-group -- Something Changed?, T.V Raman, 2020/11/07