emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Merging scratch/substitute-command-keys to master


From: Stefan Monnier
Subject: Re: Merging scratch/substitute-command-keys to master
Date: Sun, 18 Oct 2020 00:09:37 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> I tried using AUTO_STRING at first, but these strings are passed to
> Qdescribe_map_tree so that leads to segfault if there is a GC.

Oh, right!  Oops!

>> The code says VECTOR_OR_CHAR_TABLE, so your function's name might want
>> to do the same.  Or maybe call it `describe-vector` since it seems to be
>> a thin wrapper around that function.
>
> The problem is that there is already a `describe-vector' with a
> different calling convention.  So perhaps we should just go with
> `describe-vector-or-char-table' (clunky as it may be) if no one has a
> better proposal.  Or maybe `help--describe-vector' is better?  Or the
> iniquitous `help--describe-vector-or-char-table'?

I think this function's name deserves a double dash, in any case.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]