[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: empty-directory predicate, native implementation
From: |
Arthur Miller |
Subject: |
Re: empty-directory predicate, native implementation |
Date: |
Sat, 17 Oct 2020 21:03:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Michael Albinus <michael.albinus@gmx.de> writes:
> Arthur Miller <arthur.miller@live.com> writes:
>
> Hi Arthur,
>
>> I have patched handlers; which version should I make patches against:
>> current master or latest stable? How would you like patches; each in own
>> file?
>
> The patches shall be towards master. And I don't care, whether they are
> just one file, or several ones :-)
>
>> I will look at ert tests too.
>
> Thanks. Best regards, Michael.
directory-files.patch
Description: Text Data
See how this works.I have done patch between two branches.
Please check that handlers stuff. I am not sure how to test it, and am
not sure I get those correct; especially tramp-crypt.
I am using a regular expression from Dired+ by Drew in two places. I
have mention it the comment in ert tests, but don't know how to mention
it in the example in manual. Maybe remove example, or maybe it can stay
without creds?
I also discovered that I wasn't covered with FIXNUM all the way; thought
it was unsigned int so -1 would be converted into ffffffff, which
would just yeild all results. Seems like fixnum is not what I thought so I
have added test for <=0 which return nil.
Ert test are mostly foxused on new argument. I haven't found something
related to dired in test/src so I have created dired-tests.el. If it
shoudl be in some other place I can rename it.
Best regards
/a
- Re: empty-directory predicate, native implementation, (continued)
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/15
- Re: empty-directory predicate, native implementation, Michael Albinus, 2020/10/15
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/15
- Re: empty-directory predicate, native implementation, Michael Albinus, 2020/10/15
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/15
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/15
- Re: empty-directory predicate, native implementation, Michael Albinus, 2020/10/15
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/15
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/16
- Re: empty-directory predicate, native implementation, Michael Albinus, 2020/10/17
- Re: empty-directory predicate, native implementation,
Arthur Miller <=
- RE: empty-directory predicate, native implementation, Drew Adams, 2020/10/17
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/17
- RE: empty-directory predicate, native implementation, Drew Adams, 2020/10/17
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/17
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/17
- RE: empty-directory predicate, native implementation, Drew Adams, 2020/10/17
- Re: empty-directory predicate, native implementation, Arthur Miller, 2020/10/17
- Re: empty-directory predicate, native implementation, Michael Albinus, 2020/10/18
- Re: empty-directory predicate, native implementation, Eli Zaretskii, 2020/10/17
- RE: empty-directory predicate, native implementation, Drew Adams, 2020/10/18