Re: Integration of dictionary package

[Robert Pluim]

>>>>> On Thu, 8 Oct 2020 18:01:11 +0200, Torsten Hilbrich 
>>>>> <emacs.nolkaf@hilbrich.tk> said:

    Torsten> Hello,
    Torsten> by suggestion of Jean Louis I have started integrating the 
dictionary
    Torsten> package (found on https://github.com/myrkr/dictionary-el/).

    Torsten> The work can be found on the feature/integration-of-dictionary-el 
branch.

    Torsten> It contains the following commits:

    Torsten> b6227446d9 Importing dictionary module
    Torsten> 658ec3ccee Renamed connection.el
    Torsten> e2ebffdd62 Renamed link.el
    Torsten> 723906c444 Removed some compability parts in dictionary

    Torsten> I plan to integrate some future changes:

    Torsten> - support for dictionary-search to have the highlighted region as 
default
    Torsten> - support for initially looking up on localhost and the switching 
to
    Torsten> dict.org

    Torsten> Thanks for reviewing,

I took a quick look, the only comment I have is that perhaps the
defcustom's should have :version "28.1" in them, since theyʼre being
introduced in 28.1

Thanks for doing this.

Robert
--