emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warnings in mingw64 builds on master


From: Andy Moreton
Subject: Re: Warnings in mingw64 builds on master
Date: Sat, 15 Aug 2020 20:39:40 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt)

On Sat 15 Aug 2020, Eli Zaretskii wrote:

>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Sat, 15 Aug 2020 19:48:56 +0100
>> 
>> >> C:/emacs/git/emacs/master/src/w32reg.c:146:1: warning: function might be
>> >> candidate for attribute 'malloc' [-Wsuggest-attribute=malloc]
>> >>   146 | w32_get_string_resource (void *v_rdb, const char *name, const 
>> >> char *class)
>> >>       | ^~~~~~~~~~~~~~~~~~~~~~~
>> >
>> > That's just noise.  There's nothing wrong with the code.
>> 
>> Agreed. However it is better to have a clean build than to have
>> pointless warnings, so the real errors stand out.
>
> I'd rather we removed -Wsuggest-attribute=malloc from the options we
> use.

Yes - I meant that removing the warning switch is preferenable (even if
I did not manage to say so clearly).

    AndyM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]