Re: [PATCH] [WIP] Port feature/native-comp to Windows.

[Eli Zaretskii]

> From: Nicolas Bértolo <address@hidden>
> Date: Mon, 11 May 2020 23:46:09 -0300
> Cc: Andrea Corallo <address@hidden>, address@hidden
> 
> The attached patch does implement dynamic loading of libgccjit in Windows.

Thanks.

> -    LIBGCCJIT_LIB="-lgccjit -ldl"
> +    # mingw32 loads the library dynamically.
> +    if test "${opsys}" != "mingw32"; then
> +      LIBGCCJIT_LIB="-lgccjit -ldl"

libdl exists only in MinGW64, I think.

Why do you need it? is it because the code uses dlopen/dlsym
somewhere?

> +/* In alphabetical order */
> +#define gcc_jit_block_add_assignment fn_gcc_jit_block_add_assignment
> +#define gcc_jit_block_add_comment fn_gcc_jit_block_add_comment
> +#define gcc_jit_block_add_eval fn_gcc_jit_block_add_eval
> +#define gcc_jit_block_end_with_conditional 
> fn_gcc_jit_block_end_with_conditional

I think it's good to #undef each symbol before defining it.