Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages

[João Távora]

Dmitry Gutov <address@hidden> writes:

> On 12.05.2020 00:41, Jo�o T�vora wrote:
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index f5f4092..6be1500 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1,6 +1,11 @@
>>   ;;; project.el --- Operations on the current project  -*- lexical-binding: 
>> t; -*-
>>     ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
>> +;; Version: 1.0.0
>
> Please make this one "0.1".

No problem, I guess, but sure you don't want "Semantic Versioning"
stuff?  Also, why only that one ? Any reason why I shouldn't _also_ use
0.1 for eldoc.el and xref.el?

Regardless, I have two serious-ish problems here:

1. xref and project.el have a cyclic dependency.  xref.el depends
  (properly) on project.el but it seems project.el also depends on
  xref.el.


     (defun project--files-in-directory (dir ignores &optional files)
       (require 'find-dired)
       (require 'xref)
       (defvar find-name-arg)


   How should I fix this? Any ideas? Or should I be creative?

2. It'd be nice if both xref.el and project.el were available for Emacs
   26.3.  But project.el in Emacs master depends on fileloop.el, which
   in turn depends on generator.el. OK? Should I make both fileloop.el
   and generator.el :core packages, too?

   Or should I bite the bullet and let them stay on 27.1.  In that case,
   Eglot will soon start requiring Emacs 27.1 only, but I wouldn't mind
   giving some support to Eglot on 26.3.

João