Re: [PATCH] Fix display box cursor under image with margins

[Basil L. Contovounesios]

Eli Zaretskii <address@hidden> writes:

>> From: Evgeny Zajcev <address@hidden>
>> Date: Sat, 18 Apr 2020 21:05:16 +0300
>> Cc: emacs-devel <address@hidden>
>> 
>>  > Here is the patch to fix issue making cursor hollow under non-mask image, 
>> but containing margins. 
>>  This
>>  > patch keeps box cursor to be box in case image has margins.
>> 
>>  Could you please give an example of such an image and what the results
>>  look like, before and after the patch?  It's hard to understand the
>>  details of this otherwise.
>> 
>> Here is first screenshot how hollow cursor looks on image with margin -
>> http://lgarc.narod.ru/pics/emacs-hollow-cursor.png
>> 
>> And here is how it looks with patch applied - 
>> http://lgarc.narod.ru/pics/emacs-box-cursor.png
>> 
>> Without patch, look of the cursor won't change, it will remain being hollow
>
> Thanks.  Frankly, I'm not sure the change is for the better.
>
> Does anyone else have an opinion?

I think the existing hollow cursor makes it more obvious that the cursor
is over an image; the latter doesn't really betray the fact that it's a
cursor, at least to my eyes.  That said, I wouldn't be opposed to new
cursor types.

-- 
Basil