On Thu, Nov 28, 2019 at 10:08 PM Stephen Leake <address@hidden> wrote:
> I'm also assuming that whoever wrote w32_delayed_load tested calling
> GetLastError, got an unhelpful message, and deleted it. It would be nice
> if there was a comment saying that.
"Whoever wrote w32_delayed_load" didn't do that, because the already existing code
that loaded the image libraries didn't do it either. The whoever-dude just added a
mechanism to allow the user to add new image libraries on their own, which was
previously impossible because they were hard-coded (if such-and-such-v2 loads, then
good, else if such-and-such-v1 loads, then good too, else oh no!).
I'm not saying that the whoever-dude shouldn't have done what you suggest, just
that he was fixing other issue and didn't even think of calling GetLastError.
Bad, bad whoever-dude! ;-)