[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 305dbc7 2/4: Move description of value to syntax-ppss functio
From: |
Lars Ingebrigtsen |
Subject: |
Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. |
Date: |
Wed, 30 Oct 2019 16:22:50 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Dmitry Gutov <address@hidden> writes:
> Point is, in parse-partial-sexp the *can* be relied upon. Though I'm
> not sure how often they are used.
Yes, the doc string certainly implies that they can be relied upon if
you use that function instead.
On the other hand, perhaps I shouldn't have moved it --
parse-partial-sexp is used a lot, too. I was only seeing syntax-ppss
everywhere, but I see that it's used less than 2x as much.
So perhaps that patch should be reverted anyway. Or have the list in
both functions. Or, even better, stop saying
(if (nth 5 state)
(do-something-incomprehensible)
(do-something-else-incomprehensible))
everywhere and just add accessor functions already, so that the code
becomes marginally more readable. Because trying to make sense of it
now is just too hard, and it doesn't have to be.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Dmitry Gutov, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Lars Ingebrigtsen, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Dmitry Gutov, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Lars Ingebrigtsen, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Dmitry Gutov, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Lars Ingebrigtsen, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Dmitry Gutov, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Lars Ingebrigtsen, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Stefan Monnier, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Lars Ingebrigtsen, 2019/10/30
- Re: master 305dbc7 2/4: Move description of value to syntax-ppss function., Alan Mackenzie, 2019/10/30