emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dedicated window for *log-edit-files*


From: Stefan Monnier
Subject: Re: Dedicated window for *log-edit-files*
Date: Sat, 26 Oct 2019 08:00:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Probbaly, 'log-edit-show-files' should mark the window as dedicated
> only if it appears on a separate frame.

It should never appear on a separate frame, IIRC (that's the
"-same-frame" part of cvs-pop-to-buffer-same-frame).

> But the corresponding code is weird.  For starters, wrapping some sort
> of 'pop-to-buffer' in 'save-selected-window' is not reasonable IMHO.
> And both, 'cvs-pop-to-buffer-same-frame' and 'cvs-bury-buffer', should
> be eventually rewritten via 'display-buffer' such that "q" just quits
> the associated window using its 'quit-restore' parameter.

Quite so,


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]