Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring

[Ergus]

On Thu, Oct 17, 2019 at 04:26:34AM +0200, Juanma Barranquero wrote:
> On Thu, Oct 17, 2019 at 4:19 AM Lars Ingebrigtsen <address@hidden> wrote:
>
> > I thought it was kinda opposite: When it's a predicate, we only care
> > about nil/non-nil.
>
> Most predicates are defined as t/nil, like numberp, booleanp, etc. Usually,
> the code that uses them only worries about the result being nil/non-nil,
> but there are some exceptions.
>
> Anyway, if you feel strongly about anything on my recent patches, feel free
> to change it.

AFAIK: In lisp true means anything non-nil for most of the
purposes. This change I am not sure how convenient is it. It just ads
some extra complexity to read with no benefit.

Maybe it made more sense to fix the docstrings to say non-nil instead of
forcing the code to return t?