Re: Tabs

[Ergus]

On Wed, Oct 09, 2019 at 03:36:06PM +0300, Eli Zaretskii wrote:
> > Date: Wed, 9 Oct 2019 14:05:34 +0200
> > From: Ergus <address@hidden>
> > Cc: address@hidden, address@hidden, address@hidden
> >
> > >diff --git a/src/xdisp.c b/src/xdisp.c
> > >index 893ce92..f94f651 100644
> > >--- a/src/xdisp.c
> > >+++ b/src/xdisp.c
> > >@@ -11796,7 +11796,7 @@ clear_garbaged_frames (void)
> > >
> > >      if (FRAME_VISIBLE_P (f) && FRAME_GARBAGED_P (f))
> > >        {
> > >-         if (f->resized_p
> > >+         if ((f->resized_p || f->tab_bar_resized)
> > >              /* It makes no sense to redraw a non-selected TTY
> > >                 frame, since that will actually clear the
> > >                 selected frame, and might leave the selected
> >
> > No, this does nothing
>
> If you set a breakpoint in this fragment from clear_garbaged_frames:
>
>           if (FRAME_VISIBLE_P (f) && FRAME_GARBAGED_P (f))
>             {
>               if ((f->resized_p || f->tab_bar_resized)
>                   /* It makes no sense to redraw a non-selected TTY
>                      frame, since that will actually clear the
>                      selected frame, and might leave the selected
>                      frame with corrupted display, if it happens not
>                      to be marked garbaged.  */
>                   && !(f != sf && (FRAME_TERMCAP_P (f) || FRAME_MSDOS_P (f))))
>                 redraw_frame (f);  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>               else
>                 clear_current_matrices (f);
>
> does the breakpoint fire after you type "C-x 6 f"?

Yes:

Thread 1 "emacs" hit Breakpoint 1, clear_garbaged_frames () at 
../../src/xdisp.c:11805
11805                   redraw_frame (f);
(gdb) bt
#0  0x00005555555ed30c in clear_garbaged_frames () at ../../src/xdisp.c:11805
#1  0x00005555555f33c9 in redisplay_internal () at ../../src/xdisp.c:15237
#2  0x00005555555f2564 in redisplay () at ../../src/xdisp.c:14825
#3  0x0000555555775f6f in read_char (commandflag=1, map=0x55555691f1e3, 
prev_event=0x0, used_mouse_menu=0x7fffffffd171, end_time=0x0) at 
../../src/keyboard.c:2473
#4  0x00005555557858d0 in read_key_sequence (keybuf=0x7fffffffd3a0, prompt=0x0, 
dont_downcase_last=false, can_return_switch_frame=true, 
fix_current_buffer=true, prevent_redisplay=false)
   at ../../src/keyboard.c:9527
#5  0x0000555555772fbe in command_loop_1 () at ../../src/keyboard.c:1345
#6  0x0000555555896deb in internal_condition_case (bfun=0x555555772b76 
<command_loop_1>, handlers=0x90, hfun=0x5555557722e9 <cmd_error>) at 
../../src/eval.c:1355
#7  0x000055555577283b in command_loop_2 (ignore=0x0) at 
../../src/keyboard.c:1091
#8  0x000055555589665c in internal_catch (tag=0xd470, func=0x55555577280e 
<command_loop_2>, arg=0x0) at ../../src/eval.c:1116
#9  0x00005555557727d9 in command_loop () at ../../src/keyboard.c:1070
#10 0x0000555555771eb8 in recursive_edit_1 () at ../../src/keyboard.c:714
#11 0x000055555577203c in Frecursive_edit () at ../../src/keyboard.c:786
#12 0x000055555576a4a7 in main (argc=2, argv=0x7fffffffd818) at 
../../src/emacs.c:2055
(gdb) c
Continuing.

Thread 1 "emacs" hit Breakpoint 1, clear_garbaged_frames () at 
../../src/xdisp.c:11805
11805                   redraw_frame (f);
(gdb) bt
#0  0x00005555555ed30c in clear_garbaged_frames () at ../../src/xdisp.c:11805
#1  0x00005555555f33c9 in redisplay_internal () at ../../src/xdisp.c:15237
#2  0x00005555555f2564 in redisplay () at ../../src/xdisp.c:14825
#3  0x0000555555775f6f in read_char (commandflag=1, map=0x55555691f1e3, 
prev_event=0x0, used_mouse_menu=0x7fffffffd171, end_time=0x0) at 
../../src/keyboard.c:2473
#4  0x00005555557858d0 in read_key_sequence (keybuf=0x7fffffffd3a0, prompt=0x0, 
dont_downcase_last=false, can_return_switch_frame=true, 
fix_current_buffer=true, prevent_redisplay=false)
   at ../../src/keyboard.c:9527
#5  0x0000555555772fbe in command_loop_1 () at ../../src/keyboard.c:1345
#6  0x0000555555896deb in internal_condition_case (bfun=0x555555772b76 
<command_loop_1>, handlers=0x90, hfun=0x5555557722e9 <cmd_error>) at 
../../src/eval.c:1355
#7  0x000055555577283b in command_loop_2 (ignore=0x0) at 
../../src/keyboard.c:1091
#8  0x000055555589665c in internal_catch (tag=0xd470, func=0x55555577280e 
<command_loop_2>, arg=0x0) at ../../src/eval.c:1116
#9  0x00005555557727d9 in command_loop () at ../../src/keyboard.c:1070
#10 0x0000555555771eb8 in recursive_edit_1 () at ../../src/keyboard.c:714
#11 0x000055555577203c in Frecursive_edit () at ../../src/keyboard.c:786
#12 0x000055555576a4a7 in main (argc=2, argv=0x7fffffffd818) at 
../../src/emacs.c:2055
(gdb) c
Continuing.