Re: [Emacs-diffs] master 6cfda69 1/2: Add support for dealing with decoded time structures

[Basil L. Contovounesios]

address@hidden (Lars Ingebrigtsen) writes:

> branch: master
> commit 6cfda69d72cb9debefc48d0d95e341d389e7303a
> Author: Lars Ingebrigtsen <address@hidden>
> Commit: Lars Ingebrigtsen <address@hidden>
>
>     Add support for dealing with decoded time structures
>     

[...]

> --- a/lisp/calendar/time-date.el
> +++ b/lisp/calendar/time-date.el
> @@ -36,6 +36,9 @@
>  
>  ;;; Code:
>  
> +(require 'cl-lib)
> +(require 'subr-x)

The latter can be wrapped in eval-when-compile, right?

> +(defun date-days-in-month (year month)
> +  "The number of days in MONTH in YEAR."
> +  (if (= month 2)
> +      (if (date-leap-year-p year)
> +          29
> +        28)
> +    (if (memq month '(1 3 5 7 8 10 12))
> +        31
> +      30)))

Doesn't this already exist as the Gregorian calendar-last-day-of-month
in calendar.el?

[...]

Out of curiosity, where does the jurisdiction of time-date.el end and
calendar.el begin?  Is the former focussed more on internal timestamp
handling, and the latter on the more user-facing (M D Y) format and the
Calendar application?

Thanks,

-- 
Basil