Re: The netsec thread

[Robert Pluim]

>>>>> On Tue, 30 Jul 2019 13:30:56 +0200, Lars Ingebrigtsen <address@hidden> 
>>>>> said:

    Lars> Robert Pluim <address@hidden> writes:
    >> I found the bottom half of the implementation, and just wrote the top
    >> half.  Iʼm wondering if 'network-lookup-address-info' should just
    >> return 5/9 element vectors like 'network-interface-info' (for
    >> IPv4/IPv6), so that remembering to chop the port off the end becomes
    >> unnecessary.

    Lars> Makes sense, I think.

    >> Tested only on macOS so far. It covers the localhost case because
    >> 'network-interface-list' returns the loopback interface, which is true
    >> on my GNU/Linux box as well. If thereʼs a platform where thatʼs not
    >> true we'll have to adjust the test.
    >> 
    >> Robert
    >> 
    >> 2019-07-29  Robert Pluim  <address@hidden>
    >> 
    >> * lisp/net/nsm.el (nsm-network-same-subnet): New function.  Checks
    >> if an ip address is in the same subnet as another one.
    >> (nsm-should-check): Use nsm-network-same-subnet to see if we're
    >> connecting to a local subnet machine.  Remove checks for RFC1918 
addresses.

    Lars> OK; are you applying this to the netsec branch?

Yes, once Iʼve finished writing the tests, and undone the port
stripping in network-lookup-address-info, and made sure it works for
ipv6. My home internet is down at the moment, so it might be a few
days.

Robert