emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Your commit re: Fix Bug#33618; define search path variables for grep, by


From: Eli Zaretskii
Subject: Your commit re: Fix Bug#33618; define search path variables for grep, byte-compile
Date: Thu, 25 Jul 2019 19:44:12 +0300

Stephen,

The doc strings of the two new variables you added in that commit are
confusing.

  (defcustom grep-search-path '(nil)
    "Search path for grep results.
  Elements should be directory names, not file names of directories.
  The value nil as an element means to try the default directory."

  (defcustom emacs-lisp-compilation-search-path '(nil)
    "Search path for byte-compile error messages.
  Elements should be directory names, not file names of directories.
  The value nil as an element means to try the default directory."
    :version "27.1"
    :type '(repeat (choice (const :tag "Default" nil)
                           (string :tag "Directory"))))

What does it mean to "search directories for grep results" or for
"byte-compile error messages"?  Directories can only be searched for
files.  Only by reading the doc string of compilation-search-path did
I understand what you meant; please use that one as an example of how
these doc strings should be fixed.

Also, the "try the default directory" part is ambiguous (this part is
problematic also in compilation-search-path's doc string).  I'm
guessing you mean default-directory, in which case I'd suggest to say
"try the current buffer's `default-directory'" instead (if that is
accurate).

Please clarify these doc strings, as these are defcustoms, i.e. user
options.

TIA



reply via email to

[Prev in Thread] Current Thread [Next in Thread]