[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Improve Gravatar support
From: |
Andy Moreton |
Subject: |
Re: [PATCH] Improve Gravatar support |
Date: |
Tue, 23 Jul 2019 09:36:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) |
On Mon 22 Jul 2019, Basil L. Contovounesios wrote:
> Andy Moreton <address@hidden> writes:
>
>> On Mon 22 Jul 2019, Basil L. Contovounesios wrote:
>>
>>> The attached patch adds support for more Gravatar features, improves
>>> existing docs, and reduces some code duplication. WDYT?
>>
>> This patch seems to mix three things:
>> - conversion to lexical binding
>> - minor bugfixes
>> - new features
>>
>> It is better to put each in a separate patch, to ease later bisection if
>> needed.
>
> More often I see reviewers express the opposite feeling here, but since
> I don't personally mind and you asked so nicely:
Thanks. A series of simple patches is easier to review than a longer
patch that mixes several logical changes, and bisection is more likely
to return a useful answer.
The patches look good to me,
AndyM