emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch


From: Pip Cet
Subject: Re: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch
Date: Mon, 22 Jul 2019 04:12:05 +0000

On Sun, Jul 21, 2019 at 7:32 PM Paul Eggert <address@hidden> wrote:
>  static void
> -allow_garbage_collection (void *ptr)
> +allow_garbage_collection (intmax_t consing)
>  {
> -  object_ct *p = ptr;
> -  consing_until_gc = *p;
> +  consing_until_gc = consing;

Shouldn't we count the allocations that happened while GC was
inhibited and subtract them from consing_until_gc afterwards?

Also, should garbage_collect_1 use inhibit_garbage_collection rather
than fiddling with consing_until_gc directly?

Attaching a patch that does both.

Attachment: 0001-Trigger-GC-earlier-after-garbage-collection-was-inhi.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]