emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: `message' not outputting the newline "atomically"


From: Eli Zaretskii
Subject: Re: `message' not outputting the newline "atomically"
Date: Wed, 03 Jul 2019 10:47:14 +0300

> Date: Wed, 03 Jul 2019 10:41:22 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> 
> > Cc: address@hidden, address@hidden
> > From: Paul Eggert <address@hidden>
> > Date: Wed, 3 Jul 2019 00:31:18 -0700
> > 
> > Eli Zaretskii wrote:
> > > I'm okay with making 'message' write in one go to stderr, but I don't
> > > want to pay the price of having stderr buffered globally.
> > 
> > I came up with a fix that does all that. Although the fix does not alter 
> > the 
> > buffering of the stderr stream, it causes 'message' and similar functions 
> > to 
> > write in one go to avoid interleaving output. It also fixes the problem on 
> > AIX 
> > and Solaris where a single call to fprintf is implemented by multiple calls 
> > to 
> > 'write' even if the diagnostic is short, botching interleaving. It also 
> > fixes 
> > the INT_MAX overflow and memory-allocation issues of the current master's 
> > implementation of 'message'.
> 
> Whoa!  Is it really worth all that?  Including exposing this to Lisp?

Actually, this patch goes way too far.  It makes _all_ (or maybe
almost all) writes to stderr use the new line-buffered stream, which
is the same as making stderr itself line-buffered.

I only agreed to making 'message' write its text in one go.  Let's
stick to that, please.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]