[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (u
From: |
Ken Brown |
Subject: |
Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://. |
Date: |
Fri, 28 Jun 2019 03:13:40 +0000 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 6/27/2019 9:22 PM, Juanma Barranquero wrote:
>
> On Fri, Jun 28, 2019 at 1:37 AM Ken Brown <address@hidden
> <mailto:address@hidden>> wrote:
>
> > This is exactly what I said. From the context, I think it's clear that the
> > words "path", "to", and "file" don't contain slashes.
>
> If "path" does not contain slashes (with which I agree), concatenating it to
> file:/// (not file://) is the right thing to do.
No, you're forgetting the context of the test. After your change it became
(concat "file:///" file)
Here FILE is an *absolute* file name, which means it starts with a slash on a
Posix system. So you end up with four slashes. Concatenating with file:// is
the right thing to do for a POSIX-style file name, as Stefan said (and as I
said
in my original message).
Ken
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Ken Brown, 2019/06/27
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Juanma Barranquero, 2019/06/27
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Ken Brown, 2019/06/27
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Juanma Barranquero, 2019/06/27
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://.,
Ken Brown <=
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Juanma Barranquero, 2019/06/28
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Ken Brown, 2019/06/28
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Juanma Barranquero, 2019/06/28
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Ken Brown, 2019/06/28
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Juanma Barranquero, 2019/06/28
- Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://., Ken Brown, 2019/06/28